Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
A few docs updates for a CLI flag and RDS #893
Draft
+17
−4
Conversation
I had a little trouble figuring out how to configure the binlog format, hopefully this will help some others.
This flag not really documented, hopefully this clears up the intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
This PR contains some documentation updates for a CLI flag and RDS.
c29daed adds the
altercli flag to the command-line-flags document. It was a little ambiguous to me if this was supposed to be a completeALTERstatement or not, and in fact it might still be. I ran a test locally with a complete alter statement and it works. The code appears to show that is also the intention https://github.com/github/gh-ost/blob/master/go/sql/parser.go#L14.I would really like to put an example in this document for the
ALTER, but I don't know what would be good there, suggestions welcome.9dfbcc2 Adds a hint to the RDS documentation about
binlog_format. Since I ran into this issue, I thought it might help others.