close
The Wayback Machine - https://web.archive.org/web/20210628142715/https://github.com/ionic-team/ionic-framework/issues/22716
Skip to content

/ ionic-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Selecting a radio button using spacebar scrolls to end of page. #22716

Closed
kensodemann opened this issue Dec 23, 2020 · 4 comments
Closed

bug: Selecting a radio button using spacebar scrolls to end of page. #22716

kensodemann opened this issue Dec 23, 2020 · 4 comments
Labels
package: core type: bug
Projects
Ionic Core
Milestone
5.6.0

Comments

@kensodemann
Copy link
Member

@kensodemann kensodemann commented Dec 23, 2020

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
Selecting a radio button using spacebar scrolls to end of page.

Expected behavior:
Would not scroll to end

Related code:

https://github.com/ionic-afl/ionic-v5-observations.git

  1. Run in a iPhone emulation mode or some other small form factor so you cannot actually view the whole app at once.
  2. refresh to ensure nothing is selected
  3. tab to the radio area
  4. press spacebar

Once the space bar is pressed, you will have selected the first radio button, but you will have also scrolled to the bottom of the page.
@ionitron-bot
Copy link

@ionitron-bot ionitron-bot bot commented Dec 23, 2020

Thanks for the issue! This issue has been labeled as holiday triage. With the winter holidays quickly approaching, much of the Ionic Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.

In the meantime, please read our Winter Holiday Triage Guide for information on how to ensure that your issue is triaged correctly.

Thank you!
@kensodemann kensodemann added this to the a11y milestone Dec 23, 2020
@brandyscarney brandyscarney added this to Backlog 🤖 in Ionic Core via automation Feb 4, 2021
@brandyscarney brandyscarney moved this from Backlog 🤖 to On deck ⚾️ in Ionic Core Feb 4, 2021
@liamdebeasi liamdebeasi moved this from On deck ⚾️ to In progress 🤺 in Ionic Core Feb 8, 2021
@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Feb 8, 2021

Here is a dev build if anyone would like to test:

npm install @ionic/angular@5.6.0-dev.202102081600.32cdca5
@liamdebeasi liamdebeasi mentioned this issue Feb 8, 2021
Merged
4 of 13 tasks
@liamdebeasi liamdebeasi moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Feb 8, 2021
Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Feb 9, 2021
@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Feb 9, 2021

Resolved via #22892.
liamdebeasi added a commit that referenced this issue Feb 9, 2021
@liamdebeasi
fix(radio-group): pressing space no longer jumps screen to bottom of …
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3a0465e 
…page (#22892)

resolves #22716
@brandyscarney brandyscarney modified the milestones: a11y, 5.6.0 Feb 18, 2021
This was referenced Mar 13, 2021
Merged
Closed
@ionitron-bot
Copy link

@ionitron-bot ionitron-bot bot commented Mar 20, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core type: bug
Projects
Ionic Core
  
Done 🎉
Milestone
5.6.0
Linked pull requests

Successfully merging a pull request may close this issue.

fix(radio-group): pressing space no longer jumps screen to bottom of page
chore(deps): bump @ionic/react-router from 5.5.5 to 5.6.1
3 participants
@kensodemann @liamdebeasi @brandyscarney