Hey, I would be happy to improve the error messages!

Glad to hear that!

We still have to decide on how exactly this should be done, which we probably will do in tomorrows meeting. Feel free to join tomorrow (Wednesday at 15 CET, a link will be posted in gitter) in our google hangout meeting if you want to talk about it.

In any case I'll update this issue with the result of the discussion!

Thank you, @Marenz!

Hey @Marenz! Unfortunately I could not join you for the meeting today. Have you been able to reach any agreement on this issue?

Yes. We'd like for all user defined names to be in quotes in all error messages. Sorry I didn't update sooner.

In single or in double quotes?

Double quotes

I was looking into the error messages, and I have also noticed, that a lot of custom defined errors are used. The problem is that I am not totally sure, which exact errors should be changed. Could you, please, provide me with an example of any error that has "user defined names" within it that needs to be updated?

Here are a few examples for you: :)

// Uses single quotes instead of double quotes
m_errorReporter.warning(_statement.location(), "Failure condition of 'send' ignored. Consider using 'transfer' instead.");
// Should be this
m_errorReporter.warning(_statement.location(), "Failure condition of \"send\" ignored. Consider using \"transfer\" instead.");

here no quotes at all are used:

m_errorReporter.typeError(
        _statement.location(),
        errorMsg +
        ". Try converting to type " +
        valueComponentType->mobileType()->toString() +
        " or use an explicit conversion."
);
// Should be this
m_errorReporter.typeError(
        _statement.location(),
        errorMsg +
        ". Try converting to type \"" +
        valueComponentType->mobileType()->toString() +
        "\" or use an explicit conversion."
);


 m_errorReporter.fatalTypeError(_tuple.location(), "Type " + inlineArrayType->toString() + " is only valid in storage.");
// Should be this
 m_errorReporter.fatalTypeError(_tuple.location(), "Type \"" + inlineArrayType->toString() + "\" is only valid in storage.");

Hey, @Marenz Is this still left to work upon? I would be glad to contribute.

@kalashshah11 I am going to push an update in a bit with all the updated error messages I could've found

Why not introduce a toQuoted or toQuotedString helper?

@axic such as #7733 ? ;)

Can't we just implement our alternative in 3 lines of code?

Sure, that'd work

When @erak and I talked about it we decided to make it all consistent as a first step and as a second step use a function like that.

Sounds like a lot of extra work 😉

I argued along similar lines and I forgot eraks counter-argument ;)

Well, I think I had no strong opinion on the process ;-) Would agree with @axic here and start using the helper function right away.

What does that mean in regards to the pending PR?