close
The Wayback Machine - https://web.archive.org/web/20201019060903/https://github.com/github/developer.github.com/pull/392
Skip to content
This repository has been archived by the owner. It is now read-only.

Quick jump search #392

Merged
merged 52 commits into from Dec 6, 2013
Merged

Quick jump search #392

merged 52 commits into from Dec 6, 2013

Conversation

@gjtorikian
Copy link
Contributor

@gjtorikian gjtorikian commented Dec 6, 2013

/cc @tobiasahlin @github/api @github/docs-platform @jdennes @izuzak

@izuzak
Copy link
Member

@izuzak izuzak commented Dec 6, 2013

Was about to test drive this but hit a nanoc compile error. What am I doing wrong? 😄

$ nanoc compile
Loading site data…
Compiling site…

Captain! We’ve been hit!

Message:

Errno::ENOENT: No such file or directory - output/search-index.json

Compilation stack:

  (empty)

Stack trace:

  0. ./Rules:15:in `delete'
  1. ./Rules:15:in `block in load'
  2. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/base/compilation/compiler.rb:197:in `instance_eval'
  3. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/base/compilation/compiler.rb:197:in `preprocess'
  4. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/base/compilation/compiler.rb:120:in `load'
  5. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/base/compilation/compiler.rb:82:in `run'
  6. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/base/source_data/site.rb:58:in `compile'
  7. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/cli/commands/compile.rb:62:in `run'
  8. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/cli/command_runner.rb:14:in `block in call'
  9. /opt/boxen/rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/nanoc-3.4.3/lib/nanoc/cli/error_handler.rb:63:in `handle_while'
  ... 14 more lines omitted. See full crash log for details.
@gjtorikian
Copy link
Contributor Author

@gjtorikian gjtorikian commented Dec 6, 2013

@izuzak Sorry about that! Just pushed up a fix.

@izuzak
Copy link
Member

@izuzak izuzak commented Dec 6, 2013

Thanks @gjtorikian!

This looks awesome!! and for you @tobiasahlin and @gjtorikian for making this happen! Love it so much I want to push the merge button right now. 😻

izuzak added a commit that referenced this pull request Dec 6, 2013
@izuzak izuzak merged commit 84252a2 into master Dec 6, 2013
@izuzak izuzak deleted the quick-jump-search branch Dec 6, 2013
izuzak added a commit that referenced this pull request Dec 8, 2014
…-list-of-input-parameters

Remove path parameter from list of input parameters for creating commit comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.