close
Skip to content

StreamSelectLoop: Use fresh time so Timers added during stream events are accurate #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 3 commits into from
Jan 10, 2017
Merged

StreamSelectLoop: Use fresh time so Timers added during stream events are accurate #51

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbab35f
always use a fresh time when scheduling a timer; fixes #42
May 20, 2016
3b797b9
add test for #42 (timer added after blocking event handler)
May 31, 2016
ebed326
fix formatting per psr-2
andrewminerd Aug 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
always use a fresh time when scheduling a timer; fixes #42
  • Loading branch information
Andrew Minerd committed May 20, 2016
commit cbab35f957b3a05b44a84812ff216428f5e56765
2 changes: 1 addition & 1 deletion src/Timer/Timers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function getTime()
public function add(TimerInterface $timer)
{
$interval = $timer->getInterval();
$scheduledAt = $interval + $this->getTime();
$scheduledAt = $interval + microtime(true);

$this->timers->attach($timer, $scheduledAt);
$this->scheduler->insert($timer, -$scheduledAt);
Expand Down