Comment Template: Add Border Block Support#64238
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Aug 7, 2024
Member
ramonjd
left a comment
There was a problem hiding this comment.
LGTM
Border styles are output by global styles :root :where(.wp-block-comment-template), and overridden by block-level inline CSS.
97 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Comment Templateblock.Part of #43247
Why?
Comment Templateblock is missing border support.How?
Adds the border block support in block.json.
Testing Instructions
Comment Templateblock's border is Configurable via Global Styles.Comment Templateblock and Apply the border Styles.Comment Templateblock styles take precedence over global Styles.Comment Templateblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-comment-template.mp4