UnslashingFunctionsHelper::is_unslashing_function(): add tests#2715
Merged
GaryJones merged 2 commits intoApr 23, 2026
Conversation
jrfnl
approved these changes
Apr 1, 2026
Member
jrfnl
left a comment
There was a problem hiding this comment.
LGTM.
I presume you have verified that there are no stray @covers tags for this function in pre-existing tests ?
Contributor
Author
|
Thanks for your review, @jrfnl!
Yes, I have, and there are no stray |
Remove trailing `()` from the `@covers` tag and reorder `@see` to come before `@return`.
Contributor
Author
|
I pushed a new commit to this PR addressing two minor issues that I noticed while working on a similar PR:
|
Member
|
@rodrigoprimo Yes, I noticed what you mention in the second bullet (also in #2713) and the way it is now is definitely preferred, but it was not a blocker. Good catch on the first. I missed that. |
Member
|
For whomever does the second review: please squash-merge! |
GaryJones
approved these changes
Apr 23, 2026
lesterchan
added a commit
to lesterchan/WordPress-Coding-Standards
that referenced
this pull request
May 4, 2026
* upstream/develop: (223 commits) ContextHelper::is_in_type_test(): add tests (WordPress#2721) WPDBTrait::is_wpdb_method_call(): improve docblock description (WordPress#2719) ContextHelper::is_in_array_comparison(): add basic tests (WordPress#2726) ContextHelper::is_in_isset_or_empty(): add basic tests (WordPress#2725) WP/I18n: add tests for namespaced names WP/GetMetaSingle: add tests for namespaced names WP/DeprecatedParameterValues: add tests for namespaced names WP/DeprecatedParameterValues: move syntax error test to its own file WP/DeprecatedParameterValues: rename test case file WP/DeprecatedParameters: add tests for namespaced names FormattingFunctionsHelper::is_formatting_function(): add tests (WordPress#2713) UnslashingFunctionsHelper::is_unslashing_function(): add tests (WordPress#2715) GH Actions: Bump crate-ci/typos from 1.44.0 to 1.45.0 in the action-runners group (WordPress#2717) GH Actions: Bump codecov/codecov-action from 5.5.3 to 6.0.0 GH Actions: Bump ramsey/composer-install from 3.1.1 to 4.0.0 GH Actions: Bump the action-runners group with 2 updates Security/ValidatedSanitizedInput: add tests for namespaced names Apply suggestion from PR review WP/EnqueuedResourceParameters: add tests for namespaced names (WordPress#2675) GH Actions: Bump crate-ci/typos in the action-runners group ...
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for supporting PHPCS 4.0, this PR adds unit tests for the
UnslashingFunctionsHelper::is_unslashing_function()method.Suggested changelog entry
N/A
Related issues/external references
Related to: #2272