close
The Wayback Machine - https://web.archive.org/web/20201025152200/https://github.com/eclipse-theia/theia/issues/8067
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension with long text is not fully seen in view -> plugins and not tooltip #8067

Open
idantr opened this issue Jun 21, 2020 · 9 comments
Open

Comments

@idantr
Copy link
Contributor

@idantr idantr commented Jun 21, 2020

Bug Description:

Extension with long description - we do not see the full description of the plugin

Steps to Reproduce:

  1. run theia with env variable: THEIA_PLUGINS=local-dir:/<>/git/theia/plugins

screenshot:
image

Additional Information

  • Operating System: WIN
  • Theia Version: 1.2.0
@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jun 21, 2020

@idantr would you like to prepare a pull-request to add the description as part of the tooltip?

@akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 22, 2020

For VS Code extensions, you should use Extensions view, not Plugins.

@akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 22, 2020

I'm not sure that we should work on enhancing Plugins view or looking into removing it. It is not used in practice.

@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jun 22, 2020

I'm not sure that we should work on enhancing Plugins view or looking into removing it. It is not used in practice.

I asked a similar question in the past (#7375), in my opinion it is confusing to have both plugins and the extensions view. My concern however is that those that do not explicitly depend on @theia/vsx-registry will not have a view (since nothing pulls vsx-registry), and/or they might not want access to a marketplace so in that case do they add their own view? Should we add the view to api-samples as a reference?

@akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 22, 2020

My concern however is that those that do not explicitly depend on @theia/vsx-registry will not have a view (since nothing pulls vsx-registry), and/or they might not want access to a marketplace so in that case do they add their own view? Should we add the view to api-samples as a reference?

I assume they are either have own view or don't want to have view at all. Leaking dev time view to end users not really good.

@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jun 22, 2020

My concern however is that those that do not explicitly depend on @theia/vsx-registry will not have a view (since nothing pulls vsx-registry), and/or they might not want access to a marketplace so in that case do they add their own view? Should we add the view to api-samples as a reference?

I assume they are either have own view or don't want to have view at all. Leaking dev time view to end users not really good.

I'm not sure what you meant by 'dev time view', but my idea was to either:

  • remove the view completely from sources
  • remove it from the plugin-system, but add it to api-samples as an example (and since some devs use it for testing purposes)

I do not think that applications should have both views by default (when pulling vsx-registry) since they overlap and one of them (plugins) has a limited set of functionality. It also requires additional maintenance to support both (which is mainly your argument for updating the plugins-view).

@akosyakov you had some comments in the past when I removed the view:

@danarad05
Copy link
Contributor

@danarad05 danarad05 commented Sep 13, 2020

@akosyakov @vince-fugnitto @idantr
Is solution for this issue agreed upon?

@idantr
Copy link
Contributor Author

@idantr idantr commented Sep 13, 2020

@danarad05 from the above discussion @akosyakov should decide if plugins view should be removed/displayed in a different way or not.

@akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 21, 2020

You should bring unclear questions to the dev meeting where it would be decided by the community: https://github.com/eclipse-theia/theia/wiki/Dev-Meetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.