How would you expect this to be formatted? #105

jondot · 2018-05-25T17:09:54Z

this is hand-tuned, yapf/pep8 don't really care about any of that (they pass-through, it seems):

def fetch(content, prefix):
    return {
        'parts': pipe(parse('$..layers').find(content), mapcat(lambda m: m.value),
                      filter(lambda v: v['exportOptions']['exportFormats']),
                      filter(lambda v: re.match(prefix, v['name'])),
                      map(lambda v: glom(v, {'key': 'name',
                                             'layout': ('frame', {'left': ('x', round),
                                                                  'top': ('y', round),
                                                                  'width': ('width', round),
                                                                  'height': ('height', round)}) })),
                      sorted(key=lambda p: p['key']),
                      list)
    }

with prettier

def fetch(content, prefix):
    return \
        {
            "parts":
                pipe(parse("$..layers").find(content), mapcat(lambda m: \
                        m.value), filter(lambda v: \
                        v["exportOptions"]["exportFormats"]), filter(lambda \
                        v \
                    : \
                        re.match(prefix, v["name"])), map(lambda v: \
                        glom(v, {
                            "key": "name",
                            "layout":
                                (
                                    "frame",
                                    {
                                        "left": ("x", round),
                                        "top": ("y", round),
                                        "width": ("width", round),
                                        "height": ("height", round)
                                    }
                                )
                        })), sorted(key=lambda p: p["key"]), list)
        }

hawkrives · 2018-05-25T17:20:28Z

I'd probably do this by hand, but my formatting can be a bit idiosyncratic.

def fetch(content, prefix):
    return {
        'parts': 
            pipe(
                parse('$..layers').find(content), 
                mapcat(lambda m: m.value),
                filter(lambda v: v['exportOptions']['exportFormats']),
                filter(lambda v: re.match(prefix, v['name'])),
                map(lambda v: glom(v, {
                    'key': 'name',
                    'layout': (
                        'frame', 
                        {
                            'left': ('x', round),
                            'top': ('y', round),
                            'width': ('width', round),
                            'height': ('height', round)
                        }
                    ) 
                })),
                sorted(key=lambda p: p['key']),
                list
            )
    }

(I can try and write out the general rules I followed here, if this isn't too hard on the eyes.)

jondot · 2018-05-25T18:07:45Z

Looks much better! is this anything yapf/pep8/prettier could ever do?

jondot · 2018-05-26T15:09:54Z

FWIW, unrelated to this thread, I saw this project on HN this morning https://github.com/ambv/black seems to be exactly what I was looking for (an opinionated formatter), and also incidentally it formats code almost exactly like you did. hurray! :)

Aug	SEP	Oct
	28
2019	2020	2021

prettier / plugin-python Archived

How would you expect this to be formatted? #105

How would you expect this to be formatted? #105

jondot commented May 25, 2018

hawkrives commented May 25, 2018

jondot commented May 25, 2018

jondot commented May 26, 2018 •

edited

prettier / plugin-python Archived

Join GitHub today

How would you expect this to be formatted? #105

How would you expect this to be formatted? #105

Comments

jondot commented May 25, 2018

hawkrives commented May 25, 2018

jondot commented May 25, 2018

jondot commented May 26, 2018 • edited

jondot commented May 26, 2018 •

edited