feat(taxonomy): added metadata taxonomy field support - #3710
Merged
mergify[bot] merged 9 commits intoOct 15, 2024
Conversation
TylerGauntlett
force-pushed
the
metadata-taxonomy-options-api
branch
from
October 9, 2024 21:41
b007a11 to
fc302d3
Compare
TylerGauntlett
commented
Oct 9, 2024
|
|
TylerGauntlett
force-pushed
the
metadata-taxonomy-options-api
branch
from
October 11, 2024 16:21
bceaf14 to
5a4998a
Compare
…data-taxonomy-options-api # Conflicts: # package.json # src/elements/content-sidebar/MetadataInstanceEditor.tsx # src/elements/content-sidebar/MetadataSidebarRedesign.tsx # src/elements/content-sidebar/__tests__/MetadataInstanceEditor.test.tsx # yarn.lock
jmcbgaston
reviewed
Oct 15, 2024
| const params = { | ||
| ...(marker ? { marker } : {}), | ||
| ...(searchInput ? { searchInput } : {}), | ||
| ...(query_text ? { query_text } : {}), |
Contributor
There was a problem hiding this comment.
nit but should this be camel cased?
Contributor
Author
There was a problem hiding this comment.
This is intentional as the query string param is required in snake case (ie /metadata?query_text=search)
tjuanitas
approved these changes
Oct 15, 2024
| const showList = !showEditor && templateInstances.length > 0 && !editingTemplate; | ||
| const areAiSuggestionsAvailable = isExtensionSupportedForMetadataSuggestions(file?.extension ?? ''); | ||
|
|
||
| const taxonomyOptionsFetcher = async ( |
Contributor
There was a problem hiding this comment.
nit: i don't think the async is needed since we're not directly using await. the function will still be a promise since metadataTaxonomyFetcher is async
Contributor
There was a problem hiding this comment.
this repo favors utils folder path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eld (if returned by the backend)