feat(uploads): add resin tracking for uploads manager - #1384
Merged
Conversation
|
Verified that @rosepierce has signed the CLA. Thanks for the pull request! |
jstoffan
reviewed
Jul 10, 2019
| return ( | ||
| <div | ||
| className="bcu-overall-progress-bar" | ||
| data-resin-target={classNames({ |
Contributor
There was a problem hiding this comment.
Should we use classNames for non-CSS purposes? I had to look at this a few times to realize it wasn't setting actual class names.
| theme="default" | ||
| > | ||
| <PlainButton | ||
| data-resin-target="" |
Contributor
There was a problem hiding this comment.
It seems like the attribute shouldn't be applied if the value is empty.
mickr
reviewed
Jul 10, 2019
rosepierce
force-pushed
the
add-uploads-manager-resin
branch
from
July 10, 2019 21:36
d7026e9 to
150af81
Compare
rosepierce
force-pushed
the
add-uploads-manager-resin
branch
from
July 10, 2019 23:09
4d47eeb to
7f35ddf
Compare
jstoffan
approved these changes
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding resin tracking for retrying failed uploads and expanding/collapsing the uploads manager.