close
Skip to content

perf(sidebar): Lazy load sidebar panels without 500ms delay - #1223

Merged
ConradJChan merged 3 commits into
box:masterfrom
ConradJChan:faster-lazy-load
May 30, 2019
Merged

perf(sidebar): Lazy load sidebar panels without 500ms delay#1223
ConradJChan merged 3 commits into
box:masterfrom
ConradJChan:faster-lazy-load

Conversation

@ConradJChan

Copy link
Copy Markdown
Contributor

Invokes the loader function first without waiting for any delay and then rely on retryNumOfTimes in case of error

@ConradJChan
ConradJChan requested a review from a team as a code owner May 30, 2019 17:04
@boxcla

boxcla commented May 30, 2019

Copy link
Copy Markdown

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

Comment thread src/elements/common/async-load/AsyncLoad.js Outdated
jeremypress
jeremypress previously approved these changes May 30, 2019
@ConradJChan
ConradJChan merged commit bb216b4 into box:master May 30, 2019
@ConradJChan
ConradJChan deleted the faster-lazy-load branch May 30, 2019 23:04
frogzsj pushed a commit to frogzsj/box-ui-elements that referenced this pull request May 31, 2019
j3tan pushed a commit to j3tan/box-ui-elements that referenced this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants